Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#8099] Fast failure for distro sync task and verify task if cluster disconnect. #8693

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix #8099 .

Brief changelog

  • Fast failure for distro sync task and verify task if cluster disconnect.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Jul 6, 2022
@KomachiSion KomachiSion added this to the 2.1.1 milestone Jul 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.08%. Comparing base (da34fbd) to head (0b0979e).
Report is 920 commits behind head on develop.

Files Patch % Lines
...phemeral/distro/v2/DistroClientTransportAgent.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8693      +/-   ##
=============================================
+ Coverage      41.59%   42.08%   +0.49%     
- Complexity      4481     4516      +35     
=============================================
  Files            884      884              
  Lines          32245    32265      +20     
  Branches        3733     3736       +3     
=============================================
+ Hits           13412    13579     +167     
+ Misses         17478    17328     -150     
- Partials        1355     1358       +3     
Files Coverage Δ
...cos/core/cluster/remote/ClusterRpcClientProxy.java 72.85% <100.00%> (+12.25%) ⬆️
...phemeral/distro/v2/DistroClientTransportAgent.java 96.32% <95.23%> (+92.99%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da34fbd...0b0979e. Read the comment docs.

@KomachiSion KomachiSion merged commit 5aabba1 into alibaba:develop Jul 7, 2022
@KomachiSion KomachiSion deleted the develop-issue#8099 branch July 7, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

多个节点的数据不一致了
3 participants