Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8461] Enhance Nacos monitor observability system #9038

Merged
merged 8 commits into from
Oct 25, 2022
Merged

[ISSUE #8461] Enhance Nacos monitor observability system #9038

merged 8 commits into from
Oct 25, 2022

Conversation

beet233
Copy link
Contributor

@beet233 beet233 commented Aug 27, 2022

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#8461
Enhance Nacos monitor observability system.

Brief changelog

  • Add NacosMeterRegistryCenter to unite metrics registry.
  • Add config subscribers count of different versions (nacos v1/v2) .
  • Add service subscribers and publishers count of different versions (nacos v1/v2) .
  • Add fuzzy search count of config.
  • Add config read/write rt.
  • Add service change/subscribe event queue size.
  • Add service push queue size.
  • Add service empty push count.
  • Add topn most frequently changed services and configs with TopnCounterMetricsContainer.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@beet233
Enhance MetricsMonitor with several new metrics
7735e45 
* Add config read and write rt

* Add ServiceEvent publisher queue size

* Add fuzzy search count

* Add naming subscriber and publisher count with v1 or v2 version tag

* Add config subscriber count with v1 or v2 version tag
@beet233
Add pending push task count and empty push count metrics
7b88494 
* collect pending push task count by scheduled task

* add unit test for increment metrics in NacosMonitorPushResultHook
@beet233
Add topn counter container and topn config change
890a423
@beet233
Create private MeterRegistry for config change
3a9a7b5
@beet233
Add scheduled clear for config change count, add removeAll for TopnCo…
ec16918 
…unterMetricsContainer
@beet233
Add topn service change
9fa338c
@beet233
Reconstruct metrics monitor with NacosMeterRegistryCenter.
0599e8b 
* divide globalRegistry to different modules' CompositeMeterRegistry

* Add dynamic meters refresh service for config and naming module

* fix unit test
@beet233
Add try catch when init NacosMeterRegistryCenter
f6b35c7
@realJackSun realJackSun merged commit 03345fd into alibaba:asoc2022_issue#8461 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realJackSun realJackSun realJackSun approved these changes

Assignees

@realJackSun realJackSun

Labels
ASoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beet233 @CLAassistant @realJackSun @KomachiSion