Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8312] Add more mapper. #9119

Conversation

The-Gamer-01
Copy link
Contributor

Add more mapper.

What is the purpose of the change

For issue #8312

Brief changelog

Create ConfigInfoTagMapper, HisConfigInfoMapper and TenantInfoMapper.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@li-xiao-shuang li-xiao-shuang merged commit 4916493 into alibaba:summer2022_issue#8312 Sep 12, 2022
KomachiSion pushed a commit to KomachiSion/nacos that referenced this pull request Oct 24, 2022
* [ISSUE alibaba#8312] Create ConfigInfoTagMapper, HisConfigInfoMapper and TenantInfoMapper.

* [ISSUE alibaba#8312] Add more mapper.

* [ISSUE alibaba#8312]Let mappers extend Mapper.
@KomachiSion KomachiSion added Summer and removed Summer labels Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants