Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#9091] build pure nacos-client when release. #9293

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented Oct 11, 2022

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For #9091. Build pure nacos-client when release.

Brief changelog

build pure nacos-client when release.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the area/Client Related to Nacos Client SDK label Oct 11, 2022
@KomachiSion KomachiSion added this to the 2.1.2 milestone Oct 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9293 (a1b7054) into develop (9c771cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #9293   +/-   ##
==========================================
  Coverage      44.09%   44.09%           
- Complexity      4859     4862    +3     
==========================================
  Files            913      913           
  Lines          33047    33052    +5     
  Branches        3826     3828    +2     
==========================================
+ Hits           14572    14575    +3     
- Misses         17053    17057    +4     
+ Partials        1422     1420    -2     
Impacted Files Coverage Δ
...ibaba/nacos/core/distributed/raft/JRaftServer.java 61.75% <100.00%> (+0.30%) ⬆️
...m/alibaba/nacos/core/remote/ConnectionManager.java 42.89% <0.00%> (-1.48%) ⬇️
...ice/impl/PersistentClientOperationServiceImpl.java 54.16% <0.00%> (-0.99%) ⬇️
...s/naming/consistency/persistent/raft/RaftCore.java 9.68% <0.00%> (-0.20%) ⬇️
...baba/nacos/naming/healthcheck/HealthCheckTask.java 45.58% <0.00%> (ø)
...a/nacos/core/remote/control/TpsMonitorManager.java 54.77% <0.00%> (+1.27%) ⬆️
.../core/v2/event/publisher/NamingEventPublisher.java 75.00% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c191d7a...a1b7054. Read the comment docs.

@MajorHe1 MajorHe1 merged commit 1a1ef02 into alibaba:develop Oct 11, 2022
@KomachiSion KomachiSion deleted the develop-issue#9091 branch October 12, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants