Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cache removed when listeneradd delay #9311

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix cache removed when listener add delay

Brief changelog

@codecov-commenter
Copy link

Codecov Report

Merging #9311 (2a59982) into develop (83e3e50) will increase coverage by 0.01%.
The diff coverage is 62.50%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9311      +/-   ##
=============================================
+ Coverage      44.09%   44.10%   +0.01%     
- Complexity      4861     4864       +3     
=============================================
  Files            913      913              
  Lines          33052    33061       +9     
  Branches        3828     3829       +1     
=============================================
+ Hits           14574    14582       +8     
- Misses         17056    17058       +2     
+ Partials        1422     1421       -1     
Impacted Files Coverage Δ
...alibaba/nacos/client/config/impl/ClientWorker.java 55.79% <50.00%> (+0.62%) ⬆️
...om/alibaba/nacos/client/config/impl/CacheData.java 63.41% <100.00%> (+0.72%) ⬆️
...m/alibaba/nacos/core/remote/ConnectionManager.java 42.89% <0.00%> (-1.48%) ⬇️
...cos/core/cluster/remote/ClusterRpcClientProxy.java 72.85% <0.00%> (-1.43%) ⬇️
...alibaba/nacos/core/remote/control/TpsRecorder.java 74.32% <0.00%> (-1.36%) ⬇️
...a/nacos/core/remote/control/TpsMonitorManager.java 53.50% <0.00%> (-1.28%) ⬇️
...baba/nacos/naming/healthcheck/HealthCheckTask.java 45.58% <0.00%> (ø)
...s/naming/consistency/persistent/raft/RaftCore.java 9.88% <0.00%> (+0.19%) ⬆️
.../core/v2/event/publisher/NamingEventPublisher.java 76.25% <0.00%> (+7.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1ef02...2a59982. Read the comment docs.

@KomachiSion KomachiSion merged commit c4d7c33 into alibaba:develop Oct 12, 2022
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Client Related to Nacos Client SDK area/Config labels Oct 12, 2022
@KomachiSion KomachiSion added this to the 2.1.2 milestone Oct 12, 2022
@shiyiyue1102 shiyiyue1102 deleted the develop_fixlistener_miss branch October 12, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants