Add switch for naming async query. #9325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
The naming async query is for protect the UDP push failed. And in 2.0, we keep this featrue in early version for protecting some unknown problem for gRPC push.
In 2.0.X, we foung the conflicts in
reflections
package will cause the push data can't be deserializated.After 2.1.0, nacos-client remove the dependency of
reflections
, and not fount any problem for handle push data from server.So we plan add an swithes to close the async query feature in 2.1.2, and set the default value as close in 2.2.X. If no problem, will remove this feature in 2.3.X or 3.X.
Brief changelog
Add switch for naming async query.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.