Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch for naming async query. #9325

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

The naming async query is for protect the UDP push failed. And in 2.0, we keep this featrue in early version for protecting some unknown problem for gRPC push.

In 2.0.X, we foung the conflicts in reflections package will cause the push data can't be deserializated.

After 2.1.0, nacos-client remove the dependency of reflections , and not fount any problem for handle push data from server.

So we plan add an swithes to close the async query feature in 2.1.2, and set the default value as close in 2.2.X. If no problem, will remove this feature in 2.3.X or 3.X.

Brief changelog

Add switch for naming async query.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the area/Client Related to Nacos Client SDK label Oct 14, 2022
@KomachiSion KomachiSion added this to the 2.1.2 milestone Oct 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9325 (6fad9de) into develop (ee3ae00) will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9325      +/-   ##
=============================================
- Coverage      44.17%   44.09%   -0.08%     
- Complexity      4867     4869       +2     
=============================================
  Files            913      913              
  Lines          33062    33078      +16     
  Branches        3829     3830       +1     
=============================================
- Hits           14604    14587      -17     
- Misses         17037    17073      +36     
+ Partials        1421     1418       -3     
Impacted Files Coverage Δ
...n/java/com/alibaba/nacos/api/PropertyKeyConst.java 0.00% <ø> (ø)
...s/client/naming/core/ServiceInfoUpdateService.java 60.21% <33.33%> (-7.32%) ⬇️
...libaba/nacos/core/cluster/ServerMemberManager.java 72.17% <0.00%> (-4.79%) ⬇️
...a/nacos/core/remote/control/TpsMonitorManager.java 50.31% <0.00%> (-4.46%) ⬇️
...m/alibaba/nacos/core/remote/ConnectionManager.java 42.89% <0.00%> (-1.48%) ⬇️
...s/naming/consistency/persistent/raft/RaftCore.java 9.68% <0.00%> (-0.20%) ⬇️
...alibaba/nacos/core/remote/control/TpsRecorder.java 75.67% <0.00%> (+1.35%) ⬆️
...os/client/auth/ram/identify/CredentialService.java 82.69% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3ae00...6fad9de. Read the comment docs.

@KomachiSion KomachiSion merged commit 0bfd752 into alibaba:develop Oct 14, 2022
@KomachiSion KomachiSion deleted the develop-switch-async-query branch October 14, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants