[ISSUE #9415]update setExternalStorage logic,support more db check,add 8 count unit test #9470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#9415
重写提交代码,合并冲突
Nacos多数据源通用适配改造点优化建议: 修改外置存储代码判断为通用反向逻辑
增加8个单元测试代码在2个类里面:
指定单例,未指定数据库,UseExternalDB是false
指定单例,指定数据库derby,UseExternalDB是false
指定单例,指定数据库为mysql, UseExternalDB是true
指定单例,指定数据库为其他, UseExternalDB是true
指定集群,未指定数据库,UseExternalDB是true,数据库类型是mysql
指定集群,指定数据库mysql,UseExternalDB是true,数据库类型是mysql
指定集群,指定数据库derby,UseExternalDB是false,数据库类型是derby
指定集群,指定数据库其他,UseExternalDB是true,数据库类型是其他
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.