Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9584]: change overflow hidden to visible in configuration query div #9595

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

drgnchan
Copy link
Contributor

@drgnchan drgnchan commented Nov 17, 2022

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #9584

Brief changelog

change overflow hidden to visible in configuration query div

Verifying this change

image

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #9595 (2e49b96) into develop (66c3899) will increase coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9595      +/-   ##
=============================================
+ Coverage      47.62%   47.77%   +0.15%     
- Complexity      4579     4583       +4     
=============================================
  Files            855      855              
  Lines          28357    28357              
  Branches        3199     3199              
=============================================
+ Hits           13505    13548      +43     
+ Misses         13622    13578      -44     
- Partials        1230     1231       +1     
Impacted Files Coverage Δ
...m/alibaba/nacos/core/remote/ConnectionManager.java 45.85% <0.00%> (+1.47%) ⬆️
...alibaba/nacos/client/config/impl/ClientWorker.java 55.21% <0.00%> (+4.44%) ⬆️
...a/nacos/naming/healthcheck/HealthCheckReactor.java 80.00% <0.00%> (+10.00%) ⬆️
...ent/manager/impl/EphemeralIpPortClientManager.java 81.48% <0.00%> (+14.81%) ⬆️
...a/com/alibaba/nacos/core/remote/BaseRpcServer.java 89.47% <0.00%> (+26.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c3899...2e49b96. Read the comment docs.

@drgnchan drgnchan changed the title fix: change overflow hidden to visible in configuration query div [ISSUE #9584]: change overflow hidden to visible in configuration query div Nov 17, 2022
@KomachiSion KomachiSion merged commit 2ec89ae into alibaba:develop Nov 22, 2022
@KomachiSion KomachiSion added the area/Nacos console Related to Nacos consle label Nov 22, 2022
@KomachiSion KomachiSion added this to the 2.2.0 milestone Nov 22, 2022
@MrYuguangbao
Copy link

MrYuguangbao commented Nov 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nacos升级后网页管理界面没有配置导入功能
4 participants