Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default token.secret.key #9992

Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #9992 (f78431a) into develop (a6332b2) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9992      +/-   ##
=============================================
- Coverage      50.71%   50.62%   -0.10%     
- Complexity      4849     4850       +1     
=============================================
  Files            864      864              
  Lines          27493    27494       +1     
  Branches        3035     3035              
=============================================
- Hits           13943    13918      -25     
- Misses         12317    12344      +27     
+ Partials        1233     1232       -1     
Impacted Files Coverage Δ
...s/plugin/auth/impl/token/impl/JwtTokenManager.java 85.18% <100.00%> (+0.56%) ⬆️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 50.00% <0.00%> (-8.58%) ⬇️
...alibaba/nacos/client/config/impl/ClientWorker.java 51.27% <0.00%> (-4.33%) ⬇️
...os/client/auth/ram/identify/CredentialService.java 76.08% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6332b2...f78431a. Read the comment docs.

@binbin0325 binbin0325 merged commit c04b0bb into alibaba:develop Feb 22, 2023
@KomachiSion KomachiSion deleted the develop-remove-defualt-token-key branch February 22, 2023 08:00
KomachiSion added a commit to KomachiSion/nacos that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants