Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomicBucketWrapArray supports 32-bit os #429

Conversation

binbin0325
Copy link
Collaborator

Describe what this PR does / why we need it

On 32-bit os, pointers occupy 4 bytes, currently 8 bytes by default, resulting in some empty buckets

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #429 (5c2dfb5) into master (671274f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   53.43%   53.43%           
=======================================
  Files          89       89           
  Lines        5820     5820           
=======================================
  Hits         3110     3110           
  Misses       2361     2361           
  Partials      349      349           
Impacted Files Coverage Δ
core/stat/base/leap_array.go 72.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 671274f...5c2dfb5. Read the comment docs.

@sczyh30 sczyh30 added the kind/bug Something isn't working label Sep 15, 2021
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit ace810b into alibaba:master Sep 22, 2021
@sczyh30
Copy link
Member

sczyh30 commented Sep 22, 2021

Thanks!

@sczyh30 sczyh30 added this to the 1.1.0 milestone Sep 22, 2021
@sczyh30 sczyh30 linked an issue Oct 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Integer overflow on 32-bit startup
3 participants