Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add traffic routing module #543

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

saicaca
Copy link

@saicaca saicaca commented Aug 14, 2023

Describe what this PR does / why we need it

Implements #508

Does this pull request fix one issue?

Implements #508

Describe how you did it

Basically followed the design in alibaba/Sentinel#3023.

Describe how to verify it

The implementation can be verified via go test.

Special notes for reviews

This PR is currently a work in progress.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@sczyh30 sczyh30 added kind/feature Category issues or PRs related to feature request area/traffic-management Issues or PRs related to traffic management to-review PRs to review labels Aug 15, 2023
Copy link
Collaborator

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for traffic governance related code, it may be better to commit pr to a separate v2 branch

@saicaca
Copy link
Author

saicaca commented Sep 27, 2023

for traffic governance related code, it may be better to commit pr to a separate v2 branch

I don't have permission to create a new branch in this repository. Could you please help me with that?

@saicaca saicaca changed the title [WIP] feat: add traffic routing module feat: add traffic routing module Sep 27, 2023
@saicaca saicaca marked this pull request as ready for review September 27, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traffic-management Issues or PRs related to traffic management kind/feature Category issues or PRs related to feature request to-review PRs to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants