fix(staged): add no-partial option to support normal staging process #39

src/Husky/Cli/RunCommand.cs

@@ -27,6 +27,9 @@ public bool Quiet
  [CommandOption("args", 'a', Description = "Pass custom arguments to tasks")]
  public IReadOnlyList<string>? Arguments { get; set; }
 
+ [CommandOption("no-partial", 'p', Description = "Disable partial commit and temporary file generation")]
+ public bool NoPartial { get; set; }
+
  public RunCommand(IServiceProvider provider)
  {
  _provider = provider;

src/Husky/TaskRunner/ExecutableTaskFactory.cs

@@ -1,4 +1,3 @@
-using System.IO.Abstractions;
 using System.Runtime.InteropServices;
 using Husky.Services.Contracts;
 using Husky.Stdout;
@@ -9,7 +8,7 @@ namespace Husky.TaskRunner;
 
 public interface IExecutableTaskFactory
 {
- Task<IExecutableTask?> CreateAsync(HuskyTask huskyTask, string[]? optionArguments);
+ Task<IExecutableTask?> CreateAsync(HuskyTask huskyTask, IRunOption options);
 }
 
 public class ExecutableTaskFactory : IExecutableTaskFactory
@@ -26,7 +25,7 @@ public ExecutableTaskFactory(IServiceProvider provider, IGit git, IArgumentParse
  _argumentParser = argumentParser;
  }
 
- public async Task<IExecutableTask?> CreateAsync(HuskyTask huskyTask, string[]? optionArguments)
+ public async Task<IExecutableTask?> CreateAsync(HuskyTask huskyTask, IRunOption options)
  {
  if (huskyTask.Command == null)
  {
@@ -37,7 +36,7 @@ public ExecutableTaskFactory(IServiceProvider provider, IGit git, IArgumentParse
  huskyTask.Name ??= huskyTask.Command;
 
  var cwd = await _git.GetTaskCwdAsync(huskyTask);
- var argsInfo = await _argumentParser.ParseAsync(huskyTask, optionArguments);
+ var argsInfo = await _argumentParser.ParseAsync(huskyTask, options.Arguments?.ToArray());
 
  if (huskyTask.Args != null && huskyTask.Args.Length > argsInfo.Length)
  {
@@ -51,7 +50,7 @@ public ExecutableTaskFactory(IServiceProvider provider, IGit git, IArgumentParse
  RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
  && totalCommandLength > MAX_ARG_LENGTH
  )
- return CreateChunkTask(huskyTask, totalCommandLength, argsInfo, cwd);
+ return CreateChunkTask(huskyTask, totalCommandLength, argsInfo, cwd, options.NoPartial);
 
  return CreateExecutableTask(
  new TaskInfo(
@@ -60,7 +59,8 @@ public ExecutableTaskFactory(IServiceProvider provider, IGit git, IArgumentParse
  argsInfo.Select(q => q.Argument).ToArray(),
  cwd,
  huskyTask.Output ?? OutputTypes.Always,
- argsInfo
+ argsInfo,
+ options.NoPartial
  )
  );
  }
@@ -69,7 +69,8 @@ private IExecutableTask CreateChunkTask(
  HuskyTask huskyTask,
  int totalCommandLength,
  ArgumentInfo[] args,
- string cwd
+ string cwd,
+ bool noPartial
  )
  {
  var chunks = GetChunks(totalCommandLength, args);
@@ -85,7 +86,8 @@ string cwd
  chunkedArgs,
  cwd,
  huskyTask.Output ?? OutputTypes.Always,
- argInfo
+ argInfo,
+ noPartial
  );
  // staged-task
  subTasks[i] = CreateExecutableTask(taskInfo);

src/Husky/TaskRunner/IRunOption.cs

@@ -4,5 +4,6 @@ public interface IRunOption
 {
  public string? Name { get; set; }
  public string? Group { get; set; }
+ public bool NoPartial { get; set; }
  public IReadOnlyList<string>? Arguments { get; set; }
 }

src/Husky/TaskRunner/StagedTask.cs

@@ -26,6 +26,9 @@ public StagedTask(ICliWrap cliWrap, IGit git, IFileSystem fileSystem, TaskInfo t
 
  public override async Task<double> Execute()
  {
+
+ if (TaskInfo.NoPartial) return await NormalExecution();
+
  // Check if any partial staged files are present
  var diffNames = await _git.GetDiffNameOnlyAsync();
  var fileArgumentInfo = TaskInfo.ArgumentInfo.OfType<FileArgumentInfo>().ToList();
@@ -41,6 +44,24 @@ public override async Task<double> Execute()
  var executionTime = await base.Execute();
  await ReStageFiles(partialStagedFiles);
  return executionTime;
+
+ }
+
+ private async Task<double> NormalExecution()
+ {
+ var executionTime = await base.Execute();
+ // in staged mode, we should update the git index
+ try
+ {
+ await _git.ExecAsync("update-index -g");
+ }
+ catch (Exception)
+ {
+ // Silently ignore the error if happens, we don't want to break the execution
+ "⚠️ Can not update git index".Husky(ConsoleColor.Yellow);
+ }
+
+ return executionTime;
  }
 
  private async Task<double> PartialExecution(List<FileArgumentInfo> partialStagedFiles)

src/Husky/TaskRunner/TaskInfo.cs

@@ -8,7 +8,8 @@ public TaskInfo(
  string[] arguments,
  string workingDirectory,
  OutputTypes outputType,
- ArgumentInfo[] argumentInfo
+ ArgumentInfo[] argumentInfo,
+ bool noPartial
  )
  {
  Name = name;
@@ -17,6 +18,7 @@ ArgumentInfo[] argumentInfo
  WorkingDirectory = workingDirectory;
  OutputType = outputType;
  ArgumentInfo = argumentInfo;
+ NoPartial = noPartial;
  }
 
  public string Name { get; set; }
@@ -25,4 +27,5 @@ ArgumentInfo[] argumentInfo
  public string WorkingDirectory { get; set; }
  public OutputTypes OutputType { get; set; }
  public ArgumentInfo[] ArgumentInfo { get; set; }
+ public bool NoPartial { get; set; }
 }

src/Husky/TaskRunner/TaskRunner.cs

@@ -38,7 +38,7 @@ public async ValueTask Run()
  task.Name = task.Command;
 
  $"⚡ Preparing task '{task.Name}'".Husky();
- var executableTask = await _factory.CreateAsync(task, _options.Arguments?.ToArray());
+ var executableTask = await _factory.CreateAsync(task, _options);
 
  if (executableTask is null)
  continue;