Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Multiple Authors for same type of contributions #210

Closed
cstayyab opened this issue Jun 1, 2019 · 2 comments · Fixed by #127
Closed

add Multiple Authors for same type of contributions #210

cstayyab opened this issue Jun 1, 2019 · 2 comments · Fixed by #127
Assignees
@tenshiAMD
Labels
bug:confirmed bug Something isn't working good first issue Good for newcomers pinned priority: high

Comments

@cstayyab
Copy link

cstayyab commented Jun 1, 2019 •
edited
Loading

Describe the bug
It two users are mentions for same type of contribution when a pull request is co-authored by two or more people then only one user is being added

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'A pull request which have been co-authored by two or more people'
  2. Create a new comment mentioning two users for same contribution as created here

Expected behavior
Add both users for same type of contributions (code in this case)

Current Behaviour
Only one user that was mentioned first is added

Screenshot
Screenshot of comment

Additional context
This is required when two users have Co-Authored a pull request. You can read more about them ( Pull request with multiple authors ) here
@cstayyab cstayyab added the bug Something isn't working label Jun 1, 2019
@jakebolam
Copy link
Contributor

Thanks for the report @cstayyab.

I've started a PR trying to address this problem (#127), but I'm currently swamped.

PRs welcome if you can get this over the line.

@shayantist shayantist mentioned this issue Nov 21, 2020
Merged
8 tasks
@tenshiAMD tenshiAMD mentioned this issue Sep 16, 2022
Merged
@tenshiAMD tenshiAMD linked a pull request Sep 28, 2022 that will close this issue
feat: support adding multiple users in a single message #127
Merged
@tenshiAMD
Copy link
Member

PR #127 is almost done. Closing this one for now.

@tenshiAMD tenshiAMD self-assigned this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenshiAMD tenshiAMD

Labels
bug:confirmed bug Something isn't working good first issue Good for newcomers pinned priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support adding multiple users in a single message all-contributors/app
3 participants
@jakebolam @tenshiAMD @cstayyab