Remove prefix restriction. #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefixes were hitherto restricted from not colliding, i.e. prefixes `pre1` and `pre2` were forbidden. Bumped jacoco version to allow for compilation using JDK8.
|
Just my 2c, sorry if I'm wrong but the prefix restriction AFAIR was a bit different:
That means prefix It seems you are testing a different thing (projectA vs projectB), which should work anyway. |
Prefixes were hitherto restricted from not colliding, i.e. prefixes `pre` and `pre2` were forbidden.
|
Ah, I see what you mean, good point. I have changed the test to reflect that, as I want to allow the use of a shared prefix, e.g. Note that the build failure appears to be nothing I have done, it's a failure of Travis to install JDK8. |
adamdubiel
requested changes
Dec 5, 2019
src/test/groovy/pl/allegro/tech/build/axion/release/domain/VersionResolverTest.groovy
Outdated
Show resolved
Hide resolved
…into remove-prefix-restriction
- Expand docs on potential error scenario when tags and version separators collide. - Improve test legibility.
adamdubiel
reviewed
Dec 5, 2019
src/test/groovy/pl/allegro/tech/build/axion/release/domain/VersionResolverTest.groovy
Outdated
Show resolved
Hide resolved
adamdubiel
approved these changes
Dec 5, 2019
|
Done, thanks! :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefixes were hitherto restricted from not colliding, i.e. prefixes
pre1andpre2were forbidden.Bumped jacoco version to allow for compilation using JDK8.