Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced some domain config classes with java implementation #425

Merged

Conversation

Worms308
Copy link
Contributor

In this PR i have replaced classes ChecksConfig, MonorepoConfig, NextVersionConfig and NextVersionSerializer with its java implementations.

@codecov-commenter
Copy link

Codecov Report

Merging #425 (783123f) into master (62b323d) will increase coverage by 1.06%.
The diff coverage is 79.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #425      +/-   ##
============================================
+ Coverage     54.12%   55.18%   +1.06%     
- Complexity      390      412      +22     
============================================
  Files            84       86       +2     
  Lines          1661     1696      +35     
  Branches        137      134       -3     
============================================
+ Hits            899      936      +37     
+ Misses          705      703       -2     
  Partials         57       57              
Impacted Files Coverage Δ
.../release/infrastructure/config/RulesFactory.groovy 57.89% <ø> (ø)
...ld/axion/release/domain/NextVersionSerializer.java 50.00% <50.00%> (ø)
.../build/axion/release/domain/NextVersionConfig.java 80.95% <80.95%> (ø)
.../tech/build/axion/release/domain/ChecksConfig.java 100.00% <100.00%> (ø)
...ech/build/axion/release/domain/MonorepoConfig.java 100.00% <100.00%> (ø)
...frastructure/config/MonorepoPropertiesFactory.java 50.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b323d...783123f. Read the comment docs.

Copy link
Member

@bgalek bgalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx!

@bgalek bgalek merged commit 54d0933 into allegro:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants