-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releaseOnlyOnReleaseBranches & releaseBranchNames options #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgalek
force-pushed
the
releaseOnlyOnDefaultBranches
branch
3 times, most recently
from
August 25, 2024 09:20
ee9cf26
to
0889d63
Compare
bgalek
changed the title
releaseOnlyOnDefaultBranches & releaseBranchNames
releaseOnlyOnDefaultBranches & releaseBranchNames options
Aug 25, 2024
bgalek
force-pushed
the
releaseOnlyOnDefaultBranches
branch
from
August 25, 2024 09:33
0889d63
to
46143b6
Compare
bgalek
force-pushed
the
releaseOnlyOnDefaultBranches
branch
from
August 25, 2024 10:02
c63449e
to
f38f1e5
Compare
bgalek
force-pushed
the
releaseOnlyOnDefaultBranches
branch
from
August 25, 2024 10:05
f38f1e5
to
2145ee6
Compare
bgalek
changed the title
releaseOnlyOnDefaultBranches & releaseBranchNames options
releaseOnlyOnReleaseBranches & releaseBranchNames options
Aug 25, 2024
src/integration/groovy/pl/allegro/tech/build/axion/release/SimpleIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/pl/allegro/tech/build/axion/release/domain/BaseExtension.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/pl/allegro/tech/build/axion/release/domain/BaseExtension.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/pl/allegro/tech/build/axion/release/ReleaseTask.groovy
Outdated
Show resolved
Hide resolved
bgalek
force-pushed
the
releaseOnlyOnDefaultBranches
branch
from
August 26, 2024 12:33
6c62618
to
ef8b6cc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
============================================
- Coverage 63.52% 63.33% -0.19%
- Complexity 422 433 +11
============================================
Files 81 82 +1
Lines 1571 1612 +41
Branches 152 156 +4
============================================
+ Hits 998 1021 +23
- Misses 504 518 +14
- Partials 69 73 +4 ☔ View full report in Codecov by Sentry. |
src/main/groovy/pl/allegro/tech/build/axion/release/ReleaseTask.groovy
Outdated
Show resolved
Hide resolved
radoslaw-panuszewski
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to set
release
task as no-op when on selected branches.It introduces 2 new configuration properties:
releaseOnlyOnReleaseBranches
andreleaseBranchNames
releaseOnlyOnReleaseBranches
sets realise task to do nothing if the branch that it's been run on is not onreleaseBranchNames
list.fixes #796
fixes #492