Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releaseOnlyOnReleaseBranches & releaseBranchNames options #797

Merged
merged 10 commits into from
Aug 27, 2024

Conversation

bgalek
Copy link
Member

@bgalek bgalek commented Aug 24, 2024

This PR allows to set release task as no-op when on selected branches.
It introduces 2 new configuration properties: releaseOnlyOnReleaseBranches and releaseBranchNames
releaseOnlyOnReleaseBranches sets realise task to do nothing if the branch that it's been run on is not on releaseBranchNames list.

fixes #796
fixes #492

@bgalek bgalek force-pushed the releaseOnlyOnDefaultBranches branch 3 times, most recently from ee9cf26 to 0889d63 Compare August 25, 2024 09:20
@bgalek bgalek changed the title releaseOnlyOnDefaultBranches & releaseBranchNames releaseOnlyOnDefaultBranches & releaseBranchNames options Aug 25, 2024
@bgalek bgalek force-pushed the releaseOnlyOnDefaultBranches branch from 0889d63 to 46143b6 Compare August 25, 2024 09:33
@bgalek bgalek force-pushed the releaseOnlyOnDefaultBranches branch from f38f1e5 to 2145ee6 Compare August 25, 2024 10:05
@bgalek bgalek changed the title releaseOnlyOnDefaultBranches & releaseBranchNames options releaseOnlyOnReleaseBranches & releaseBranchNames options Aug 25, 2024
@bgalek bgalek force-pushed the releaseOnlyOnDefaultBranches branch from 6c62618 to ef8b6cc Compare August 26, 2024 12:33
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 56.45161% with 27 lines in your changes missing coverage. Please review.

Project coverage is 63.33%. Comparing base (bf298be) to head (6590f10).
Report is 1 commits behind head on main.

Files Patch % Lines
...ch/build/axion/release/domain/VersionConfig.groovy 36.36% 4 Missing and 3 partials ⚠️
...llegro/tech/build/axion/release/ReleaseTask.groovy 0.00% 6 Missing ⚠️
.../tech/build/axion/release/CreateReleaseTask.groovy 0.00% 5 Missing ⚠️
...egro/tech/build/axion/release/domain/Releaser.java 66.66% 3 Missing ⚠️
.../build/axion/release/domain/scm/ScmProperties.java 66.66% 2 Missing ⚠️
...ech/build/axion/release/domain/scm/ScmService.java 0.00% 2 Missing ⚠️
.../axion/release/ReleaseBranchesConfiguration.groovy 83.33% 0 Missing and 1 partial ⚠️
...structure/git/SystemReaderWithoutSystemConfig.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #797      +/-   ##
============================================
- Coverage     63.52%   63.33%   -0.19%     
- Complexity      422      433      +11     
============================================
  Files            81       82       +1     
  Lines          1571     1612      +41     
  Branches        152      156       +4     
============================================
+ Hits            998     1021      +23     
- Misses          504      518      +14     
- Partials         69       73       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgalek bgalek merged commit 826133b into main Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants