Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScmPushResultOutcome introduced #800

Merged
merged 2 commits into from
Aug 27, 2024
Merged

ScmPushResultOutcome introduced #800

merged 2 commits into from
Aug 27, 2024

Conversation

bgalek
Copy link
Member

@bgalek bgalek commented Aug 27, 2024

ScmPushResultOutcome introduced instead of boolean value, fixes bug when GITHUB_OUTPUT should be empty when release task was skipped

@bgalek bgalek changed the title ScmPushResultOutcome introduced instead of boolean value, fixes bug w… ScmPushResultOutcome introduced Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.36%. Comparing base (b84cd97) to head (c9c6676).
Report is 1 commits behind head on main.

Files Patch % Lines
...llegro/tech/build/axion/release/ReleaseTask.groovy 0.00% 6 Missing ⚠️
...egro/tech/build/axion/release/domain/Releaser.java 0.00% 2 Missing ⚠️
...xion/release/infrastructure/git/GitRepository.java 33.33% 0 Missing and 2 partials ⚠️
...ro/tech/build/axion/release/PushReleaseTask.groovy 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #800      +/-   ##
============================================
+ Coverage     63.33%   63.36%   +0.02%     
- Complexity      433      434       +1     
============================================
  Files            82       83       +1     
  Lines          1612     1616       +4     
  Branches        156      157       +1     
============================================
+ Hits           1021     1024       +3     
- Misses          518      519       +1     
  Partials         73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…hen GITHUB_OUTPUT should be empty when release task was skipped
@bgalek bgalek merged commit ec7fe55 into main Aug 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants