Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConcurrentModificationException in SnapshotDependenciesChecker #819

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

imvs
Copy link
Contributor

@imvs imvs commented Sep 21, 2024

Hi, this helps to avoid ConcurrentModificationException in SnapshotDependenciesChecker.snapshotVersions.
Related issue #818

@bgalek
Copy link
Member

bgalek commented Sep 23, 2024

LGTM, thx!

@bgalek bgalek merged commit 0e15a62 into allegro:main Sep 23, 2024
1 check passed
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 64.21%. Comparing base (428ee60) to head (4e6ca3e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../release/domain/SnapshotDependenciesChecker.groovy 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #819      +/-   ##
============================================
- Coverage     64.53%   64.21%   -0.32%     
  Complexity      442      442              
============================================
  Files            82       82              
  Lines          1613     1621       +8     
  Branches        159      160       +1     
============================================
  Hits           1041     1041              
- Misses          503      511       +8     
  Partials         69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants