Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify clearml-agent to accept urlib>=2 as a dependency. #171

Open
jday1 opened this issue Oct 27, 2023 · 2 comments
Open

Modify clearml-agent to accept urlib>=2 as a dependency. #171

jday1 opened this issue Oct 27, 2023 · 2 comments

Comments

@jday1
Copy link
Contributor

jday1 commented Oct 27, 2023

urlib3 is limited to v1 (urllib3>=1.21.1,<1.27.0).

Hopefully, this can be modified to something like urllib3>=1.21.1,<2.0.7.

Pytorch lightning's standard for this is urllib3<4.0.

See PR: #172

@benglewis
Copy link

Please can you release the urllib3 requirement or increase the upper version limit if necessary. This is such a strange restriction

@jkhenning
Copy link
Member

Hi @benglewis, there's an open PR for this, and we basically just want to make sure this will not break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants