This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Updates for new data loading API #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
commented
Jul 30, 2020
| @@ -17,7 +17,7 @@ DOCKER_RUN_CMD = docker run --rm \ | |||
| -v $$HOME/.allennlp:/root/.allennlp \ | |||
| -v $$HOME/.cache/torch:/root/.cache/torch \ | |||
| -v $$HOME/nltk_data:/root/nltk_data | |||
| ALLENNLP_COMMIT_SHA = $(shell git ls-remote https:/allenai/allennlp master | cut -f 1) | |||
| ALLENNLP_COMMIT_SHA = $(shell git ls-remote https:/epwalsh/allennlp data-loading | cut -f 1) | |||
There was a problem hiding this comment.
TODO: change this back
Suggested change
| ALLENNLP_COMMIT_SHA = $(shell git ls-remote https:/epwalsh/allennlp data-loading | cut -f 1) | |
| ALLENNLP_COMMIT_SHA = $(shell git ls-remote https:/allenai/allennlp master | cut -f 1) |
dirkgr
added a commit
that referenced
this pull request
Jan 26, 2021
* temporarily patch allennlp to data-loading branch * run on vision PRs * Updates for new data loading API (#101) * updates for new data loading * implement sharding for squad readers * implement apply_token_indexers * update tests * fixes * fixes * fix * fix image build * make linter happy * try setting seed * refactor lm tests * update CHANGELOG * undo branch patch * ensure vision CI runs on every commit (#120) * ensure vision CI runs on every commit * try fix CHANGELOG check * improve generation dataset readers (#122) * improve generation dataset readers * clean up * format * fix TransformerQA predictor test (#145) (#146) Co-authored-by: Evan Pete Walsh <[email protected]> * Training config test fix (#157) * fix training configs and config tests * update CHANGELOG * fix * fix test-install CI job (#172) * fix test-install CI job * show pip freeze output * fix * fix LM training config * fix SNLI reader * VE model card (#189) * task card and model card for visual entailment * update archive * fixes for data loading updates in core (#192) * fixes for data loading updates in core * fix * fix piqa reader test * Moving vision models (#199) * Moving vision models * Formatting * Prepare for release v2.0.0rc1 * Forgot some changes in the Changelog * Run against the main branch of allennlp Co-authored-by: Dirk Groeneveld <[email protected]> Co-authored-by: Akshita Bhagia <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates on the models side corresponding allenai/allennlp#4497