This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Update some models for AMP training #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current failure may be related to pytorch/pytorch#36428, but note that we're actually using |
matt-gardner
approved these changes
Aug 7, 2020
| overrides="{'trainer.use_amp':true,'trainer.cuda_device':0}", | ||
| ) | ||
|
|
||
| # NOTE: as of writing this test, AMP does not work with RNNs. Hence we had |
There was a problem hiding this comment.
Again here, holdover from earlier.
Co-authored-by: Matt Gardner <[email protected]>
epwalsh
commented
Aug 10, 2020
epwalsh
commented
Aug 10, 2020
epwalsh
commented
Aug 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes models that use an RNN cell by wrapping the forward call to the cell within an
autocast(False)context.