This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
validate pretrained configs in CI #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
matt-gardner
approved these changes
Aug 14, 2020
| patch_glove(value) | ||
|
|
||
|
|
||
| DATASET_PATCHES: Dict[Path, Tuple[str, ...]] = { |
There was a problem hiding this comment.
Wow, black did something pretty bad with this one...
| "validation_data_path": "https://allennlp.s3.amazonaws.com/datasets/squad/squad-dev-v1.1.json", | ||
| "train_data_path": std.extVar("SQUAD_TRAIN"), | ||
| "validation_data_path": std.extVar("SQUAD_DEV"), | ||
| // You can replace the above two lines with these to get the actual squad datasets. |
There was a problem hiding this comment.
Adding this same comment in other config files would be nice. Hmm, looks like you have it in most, but not BART or SWAG.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes allenai/allennlp#3649 by making sure every part of each training config can be instantiated. This CI job (called "Training Configs") will only run on master pushes and nightly builds to keep our CI snappy on pull requests.