This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
dont add START and END tokens to source in CopyNet #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
approved these changes
Jun 23, 2020
| "This may result in errors or duplicate special tokens in your source sequences. ", | ||
| UserWarning, | ||
| ) | ||
| if ( |
There was a problem hiding this comment.
This warning still seems reasonable.
| tokenized_source.append(Token(END_SYMBOL)) | ||
| if not tokenized_source: | ||
| # If the tokenized source is empty, it will cause issues downstream. | ||
| raise ConfigurationError( |
There was a problem hiding this comment.
I don't think ConfigurationError is the right thing here. We should probably move away from using it anywhere except in FromParams and Registrable, preferring ValueError or whatever other error is appropriate. This one looks like a ValueError to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to our discussion here: #76 (comment)