This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix the initializer of BIMPM model #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Awesome, thanks! We've been wanting to add some tests to make sure these aren't broken (see allenai/allennlp#3649), but we haven't done that yet, so these might be all over the place, as you've noticed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar issue with allenai/allennlp#4419
BIMPM in allennlp-models still used the old version of initializer. (But the
experiment.jsonin thetest_fixturesis right, see https:/allenai/allennlp-models/blob/master/test_fixtures/pair_classification/bimpm/experiment.json)I am now upgrading our code from
allennlp<=0.9.0toallennlp==1.0.0.Thanks for your great work in the latest version.