Adding a metadata field to the basic classifier (#5104)

* Adding metadata parameter to BasicClassifier * Fix * Updating the changelog * reformatting * updating parameter type * fixing import Co-authored-by: Dirk Groeneveld <[email protected]>
allenai · Apr 22, 2021 · bd953d9 · bd953d9
1 parent 01e5083
commit bd953d9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -232,6 +232,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Renamed module `allennlp.data.tokenizers.token` to `allennlp.data.tokenizers.token_class` to avoid
  [this bug](https:/allenai/allennlp/issues/4819).
 - `transformers` dependency updated to version 4.0.1.
+- `BasicClassifier`'s forward method now takes a metadata field.
 
 ### Fixed
 

diff --git a/allennlp/models/basic_classifier.py b/allennlp/models/basic_classifier.py
@@ -4,6 +4,7 @@
 import torch
 
 from allennlp.data import TextFieldTensors, Vocabulary
+from allennlp.data.fields import MetadataField
 from allennlp.models.model import Model
 from allennlp.modules import FeedForward, Seq2SeqEncoder, Seq2VecEncoder, TextFieldEmbedder
 from allennlp.nn import InitializerApplicator, util
@@ -89,7 +90,10 @@ def __init__(
  initializer(self)
 
  def forward( # type: ignore
- self, tokens: TextFieldTensors, label: torch.IntTensor = None
+ self,
+ tokens: TextFieldTensors,
+ label: torch.IntTensor = None,
+ metadata: MetadataField = None,
  ) -> Dict[str, torch.Tensor]:
 
  """