Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetConditionCodes is missing from the library #287

Open
gcatlin opened this issue Jul 2, 2024 · 4 comments
Open

GetConditionCodes is missing from the library #287

gcatlin opened this issue Jul 2, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gcatlin
Copy link
Contributor

gcatlin commented Jul 2, 2024

https://docs.alpaca.markets/reference/stockmetaconditions-1

@gnvk gnvk added good first issue Good for newcomers enhancement New feature or request labels Jul 2, 2024
@ankitsridhar16
Copy link
Contributor

ankitsridhar16 commented Jul 3, 2024

is the requirement for the ticket to implement this rest route ?

@gcatlin
Copy link
Contributor Author

gcatlin commented Jul 3, 2024

Yes, exactly. It also entails creating a new Conditions entity, ConditionType enum, and Tape enum. The response body looks like this:

{
  "4": "On Demand Intra Day Auction",
  "A": "Slow Quote Offer Side",
  "B": "Slow Quote Bid Side",
  "C": "Closing Quote",
  "E": "Slow Quote LRP Bid Side",
  "F": "Slow Quote LRP Offer Side",
  "H": "Slow Quote Bid And Offer Side",
  "L": "Market Maker Quotes Closed",
  "N": "Non Firm Quote",
  "O": "Opening Quote",
  "R": "Regular Market Maker Open",
  "U": "Slow Quote LRP Bid And Offer",
  "W": "Slow Quote Set Slow List"
}

I'd have the function return a []Condition, where Condition has fields: Tape, Type, Code, Description.

I'd probably name the function GetConditions. All of this goes in the marketdata package.

@ankitsridhar16
Copy link
Contributor

Okay you can assign me the issue I would like to work on this

@gcatlin
Copy link
Contributor Author

gcatlin commented Jul 4, 2024

I don't have access to assign it to you, but it's safe for you to start working on it. Thanks for taking these issues on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants