Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetAssetsRequest.AssetClass should be type AssetClass (instead of string) #293

Open
gcatlin opened this issue Jul 2, 2024 · 0 comments
Open

GetAssetsRequest.AssetClass should be type AssetClass (instead of string) #293

gcatlin opened this issue Jul 2, 2024 · 0 comments
Labels
v4 Backward incompatible change that can added in the next major version

Comments

@gcatlin
Copy link
Contributor

gcatlin commented Jul 2, 2024 •
edited
Loading

There is already an AssetClass type, so it's just a matter of using it.

That is, change this:

type GetAssetsRequest struct {
	Status     string
	AssetClass string
	Exchange   string
}

To this:

type GetAssetsRequest struct {
	Status     string
	AssetClass AssetClass
	Exchange   string
}
@gnvk gnvk added the v4 Backward incompatible change that can added in the next major version label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v4 Backward incompatible change that can added in the next major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gcatlin @gnvk