Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump doorkeeper from 5.6.6 to 5.6.7 #2541

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 23, 2023

Bumps doorkeeper from 5.6.6 to 5.6.7.

Release notes

Sourced from doorkeeper's releases.

v5.6.7

  • #1662 Specify uri_redirect validation class explicitly.
  • #1652 Add custom attributes support to token generator.
  • #1667 Pass client instead of grant.application to find_or_create_access_token.
  • #1673 Honor custom_access_token_attributes in client credentials grant flow.
  • #1676 Improve AuthorizationsController error response handling
  • #1677 Fix URIHelper.valid_for_authorization? breaking for non url URIs.
Changelog

Sourced from doorkeeper's changelog.

5.6.7

  • #1662 Specify uri_redirect validation class explicitly.
  • #1652 Add custom attributes support to token generator.
  • #1667 Pass client instead of grant.application to find_or_create_access_token.
  • #1673 Honor custom_access_token_attributes in client credentials grant flow.
  • #1676 Improve AuthorizationsController error response handling
  • #1677 Fix URIHelper.valid_for_authorization? breaking for non url URIs.
Commits
  • 6692812 Release 5.6.7 🎉
  • 59162b0 Merge pull request #1677 from UnidyID/main
  • 9e16f3c Fix URIChecker.loopback_uri? failing for non url URIs
  • 9fc81d5 Merge pull request #1676 from camero2734/authorizations-controller-response
  • 41ae563 Use existing handle_auth_errors option instead of creating a new one
  • 423dbe4 Check that state is returned in redirect, according to spec
  • 21362a9 Add CHANGELOG entry; Fix spec wording; Add section to initializer template
  • cfeb444 Fix and add specs for raise_exception! handling
  • 09142d0 Add option to avoid introducing a breaking change
  • 6cd5cca Set status of response to error status
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Nov 23, 2023
Copy link

This application is owned by the Access & Permissions team.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@chrisroos
Copy link
Contributor

@dependabot rebase

Bumps [doorkeeper](https:/doorkeeper-gem/doorkeeper) from 5.6.6 to 5.6.7.
- [Release notes](https:/doorkeeper-gem/doorkeeper/releases)
- [Changelog](https:/doorkeeper-gem/doorkeeper/blob/main/CHANGELOG.md)
- [Commits](doorkeeper-gem/doorkeeper@v5.6.6...v5.6.7)

---
updated-dependencies:
- dependency-name: doorkeeper
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/doorkeeper-5.6.7 branch from 7dd5c2b to e852270 Compare November 27, 2023 12:14
Copy link
Contributor

@chrisroos chrisroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving given that it's a patch version bump and the tests pass.

Note that this version bump includes doorkeeper-gem/doorkeeper#1676, which makes changes to Doorkeeper's AuthorizationsController. We inherit from and override this controller in our SigninRequiredAuthorizationsController and so won't benefit from these controller changes in the latest version. A quick inspection suggests that we're already out of sync with Doorkeeper AuthorizationsController so I don't think we're making anything worse by merging this PR.

@chrisroos chrisroos merged commit 077d2c3 into main Nov 27, 2023
14 checks passed
@chrisroos chrisroos deleted the dependabot/bundler/doorkeeper-5.6.7 branch November 27, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant