Github action: add deploy workflow #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junghans, this is awesome, thanks for the contribution! Overall, LGTM. Before merging this PR, let me play with the config to make sure it takes care of all / most of use cases. |
alshedivat
reviewed
Jan 4, 2021
junghans
commented
Jan 4, 2021
alshedivat
approved these changes
Jan 5, 2021
Co-authored-by: Maruan <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Jan 5, 2021
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]> [ci skip]
song-qun
pushed a commit
to song-qun/song-qun.github.io
that referenced
this pull request
Mar 19, 2021
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]>
abojchevski
pushed a commit
to abojchevski/abojchevski.github.io
that referenced
this pull request
May 16, 2021
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]>
MichaelHilton
pushed a commit
to MichaelHilton/MichaelHilton.github.io
that referenced
this pull request
Jul 22, 2021
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]>
clandais
pushed a commit
to clandais/clandais.github.io
that referenced
this pull request
Oct 13, 2023
This fixes issues mentioned in alshedivat#163
antchristou
pushed a commit
to antchristou/antchristou.github.io
that referenced
this pull request
Nov 20, 2023
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically deploy the page when pushing to source branch (i.e.
masterandsource).That basically allows editing through the GitHub web interface, no more need to install bundler locally.
This also supports pull requests, which can be useful to collaboratively make a conference page. For PRs the whole build is still done except the actual
git pushat the end. To achieve this I added a--dry-runoption tobin/deploy.Side notes:
--verboseoption to make debugging ofbin/deployeasierexit 0)--useroption callingshifttwicemaster/source(and PR to these, but PR are not deployed)..github.iorepo, the deploy branch is switched fromgh-pagestomaster.bin/deployare backward compatible