Add build subcommand for building project
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
approved these changes
Sep 21, 2018
| <natures> | ||
| <nature>org.python.pydev.pythonNature</nature> | ||
| </natures> | ||
| </projectDescription> |
There was a problem hiding this comment.
I'll let adding these slide. :]
altendky
requested changes
Sep 22, 2018
|
github.com/epcpower/ccstudiodss/commit/0641a7d5924b5ba1686f6b7f70ec881b1b6e998d |
|
Sorry, I see the click link now. Here's the basic conversion but I'll gander through the link for something niftier. Maybe an actual click type. build_type_strings = [build_type.name for build_type in Build types]
build_type = BuildTypes[chosen_string] |
|
Yeah, no named tuple. Stdlib Enum or enum34 from PyPI. Either PR for Click similar to the last suggestion in the ticket or something like I have above. I haven't contributed to click so I don't know how the process goes with them. |
altendky
approved these changes
Sep 26, 2018
|
Note that GitHub inserts the commits into the history here so no need to link them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move build functionality from grid-tied.