Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed old lg workflow, updated new workflow airflow payload #1776

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

petejanuszewski1
Copy link
Contributor

Closes #1775

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7477bd0) 98.75% compared to head (fcfdbdb) 98.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1776   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          98       98           
  Lines       11953    11953           
=======================================
  Hits        11804    11804           
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -34,11 +34,9 @@ jobs:
--data-raw '{
"conf": {
"description": null,
"lg_branch": "lg_baton_airflow",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to specify the branch?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably defaults to main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly, default is main and that is set in Airflow. That branch was added while we were still in the development phase.

Copy link
Collaborator

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petejanuszewski1 petejanuszewski1 merged commit bf5c2aa into main Sep 20, 2023
37 checks passed
@petejanuszewski1 petejanuszewski1 deleted the 1775_remove_old_lg_workflow branch September 20, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove old performance test workflow (non airflow)
2 participants