Update URDF parsing logic and improve R/W operations on files #100
+215
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoferigo
reviewed
Oct 14, 2024
Comment on lines
+25
to
+32
| ## Hack to remove the encoding urdf, see https:/icub-tech-iit/ergocub-gazebo-simulations/issues/49 | ||
| with open(model_path, "r", encoding="utf-8") as robot_file: | ||
| robot_urdf_string = ( | ||
| robot_file.read() | ||
| .replace("<?xml", "") | ||
| .replace("version='1.0'", "") | ||
| .replace("encoding='UTF-8'?>", "") | ||
| ) |
There was a problem hiding this comment.
@traversaro @CarlottaSartore did ros/urdf_parser_py#83 fix ros/urdf_parser_py#82? If yes, maybe these lines that remove the encoding can be removed.
There was a problem hiding this comment.
I think so, but no release was done, so I guess the issue is still present in the latest release, and the problem is also that the pypi package is abandoned.
There was a problem hiding this comment.
Ok I see, so probably the solution for ADAM is to just migrate to something else, at one point in the future. Thanks for the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the parsing logic for URDF files by bounding the check on file existence to the maximum path length allowed by the OS. Moreover, some changes were made to make the RW operations on files safer and some final linting was performed.
Closes ami-iit/comodo#21
📚 Documentation preview 📚: https://adam-docs--100.org.readthedocs.build/en/100/