Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of brew from CI #76

Merged
merged 3 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 4 additions & 25 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
build_type: [Release, Debug]
os: [ubuntu-latest, macOS-latest]
os: [ubuntu-latest]
fail-fast: false

steps:
Expand All @@ -31,20 +31,11 @@ jobs:

# Remove apt repos that are known to break from time to time
# See https:/actions/virtual-environments/issues/323
- name: Remove broken apt repos [Ubuntu]
if: matrix.os == 'ubuntu-latest'
- name: Remove broken apt repos
run: |
for apt_file in `grep -lr microsoft /etc/apt/sources.list.d/`; do sudo rm $apt_file; done


- name: Dependencies [macOS]
if: matrix.os == 'macOS-latest'
run: |
brew update
brew install libmatio eigen

- name: Dependencies [Ubuntu]
if: matrix.os == 'ubuntu-latest'
- name: Dependencies
run: |
sudo apt-get update
sudo apt-get install libmatio-dev valgrind libeigen3-dev
Expand Down Expand Up @@ -77,9 +68,7 @@ jobs:
# CMAKE-BASED PROJECT
# ===================


- name: Configure [Ubuntu]
if: matrix.os == 'ubuntu-latest'
- name: Configure
shell: bash
run: |
mkdir -p build
Expand All @@ -89,16 +78,6 @@ jobs:
-DBUILD_TESTING:BOOL=ON \
-DFRAMEWORK_RUN_Valgrind_tests:BOOL=ON ..

- name: Configure [macOS]
if: matrix.os == 'macOS-latest'
shell: bash
run: |
mkdir -p build
cd build
cmake -DCMAKE_PREFIX_PATH=${GITHUB_WORKSPACE}/install/deps \
-DCMAKE_INSTALL_PREFIX=${GITHUB_WORKSPACE}/install \
-DBUILD_TESTING:BOOL=ON ..

- name: Build
shell: bash
run: |
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased]
- Remove use of brew from CI [#76](https:/ami-iit/matio-cpp/pull/76)
-
## [0.2.3] - 2023-11-15
- Added example. It is tested in CI. [#67](https:/ami-iit/matio-cpp/pull/67)
- Clarify how to install matio with conda-forge [#68](https:/ami-iit/matio-cpp/pull/68)
- Support finding visit_struct in the system also if it is installed without any CMake config file [#70](https:/ami-iit/matio-cpp/pull/70)
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ It can be used for reading and writing binary MATLAB `.mat` files from C++, with

The depencies are [``CMake``](https://cmake.org/) (minimum version 3.10) and [``matio``](https:/tbeu/matio). While we suggest to follow the build instructions provided in the [``matio`` home page](https:/tbeu/matio), it can also installed from common package managers:
- Linux: ``sudo apt install libmatio-dev``
- macOS: ``brew install libmatio``
- Windows (but also Linux and macOS), via [``conda-forge``](https://conda-forge.org/): ``mamba install -c conda-forge libmatio``
- Linux, macOS, Windows, via [``conda-forge``](https://conda-forge.org/): ``mamba install -c conda-forge libmatio``

[`Eigen`](https://eigen.tuxfamily.org/index.php) is an optional dependency. If available, some conversions are defined.

Expand Down