Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-11680259: avoid throwing remote context error in canParse method #581

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

arielmirra
Copy link
Contributor

No description provided.

@arielmirra arielmirra self-assigned this Feb 22, 2023
@tomsfernandez
Copy link
Contributor

The fix is great but please change how the AMFGraphPlugin is registered to only parse root files. This way we depend on declarative configuration, not imperative code logic

nschejtman
nschejtman previously approved these changes Feb 22, 2023
@nschejtman
Copy link
Contributor

The fix is great but please change how the AMFGraphPlugin is registered to only parse root files. This way we depend on declarative configuration, not imperative code logic

This is optional, the try-catch makes more sense as a fix

@tomsfernandez
Copy link
Contributor

@arielmirra can't we change the context jsonld parser to return something a bit more meaningfull and avoid throwing the exception ?

@tomsfernandez
Copy link
Contributor

@nschejtman what will happen once we implement remote context parsing ? This test will break. Exception caching is just a patch for me

@arielmirra arielmirra merged commit b9e4135 into develop Feb 23, 2023
@arielmirra arielmirra deleted the W-11680259 branch February 23, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants