W-10736116: fix transformation for array with any type items #1324
Conversation
| @@ -34,11 +32,12 @@ case class PropertyShapeTransformer(property: PropertyShape, ctx: ShapeTransform | |||
| propertyMapping | |||
| } | |||
|
|
|||
| private def transformArray(array: ArrayShape) = { | |||
| private def transformArray(array: ArrayShape): Unit = { | |||
| propertyMapping.withAllowMultiple(true) | |||
| array.items match { | |||
There was a problem hiding this comment.
Can't we just call the root schema transformation here? A possible blocker is that we don't accept ScalarShapes as roots but can this be a possible case?
There was a problem hiding this comment.
Yes, that is the problem to call the root. Also calling the root transformation will extract the mapping to a declaration, for scalars this makes no sense.
| @@ -34,11 +32,12 @@ case class PropertyShapeTransformer(property: PropertyShape, ctx: ShapeTransform | |||
| propertyMapping | |||
| } | |||
|
|
|||
| private def transformArray(array: ArrayShape) = { | |||
| private def transformArray(array: ArrayShape): Unit = { | |||
There was a problem hiding this comment.
What about array of arrays ?
There was a problem hiding this comment.
Same as the previous. We should accept it at root level, because we need to extract it to a declaration with the current behavior. I will report another issue to support this, it is not trivial to refactor this.
| @@ -0,0 +1,20 @@ | |||
| #%Dialect 1.0 | |||
| nodeMappings: | |||
There was a problem hiding this comment.
Do we have tests for other types of array types ?
There was a problem hiding this comment.
Same as the previous one. For scalars and objects is tested, no specifical tests but tested in others.
No description provided.