W-10663809 - Added in conversion support to extended schemas and if/then/else #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsfernandez
previously approved these changes
Mar 16, 2022
| @@ -0,0 +1,39 @@ | |||
| #%Dialect 1.0 | |||
| nodeMappings: | |||
| Child: | |||
There was a problem hiding this comment.
Weren't we going to add something to avoid creating this empty mapping ? Don't really care if it is left empty, just asking. Asking because the root schema has properties
There was a problem hiding this comment.
I think is better like this, to have the same behavior in all cases.
looseale
force-pushed
the
W-10663809-extended-schema
branch
2 times, most recently
from
5391665
to
f487302
Compare
tomsfernandez
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on aml-org/amf-aml#493