Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W 10674627: parse GraphQL type extensions #1416

Merged
merged 1 commit into from
May 27, 2022
Merged

W 10674627: parse GraphQL type extensions #1416

merged 1 commit into from
May 27, 2022

Conversation

nschejtman
Copy link
Contributor

@nschejtman nschejtman commented May 26, 2022

  • Rename GraphQL inheritance parsing -> interface parsing
  • W-10674627: parse GraphQL type extensions

When we parse schema extensions we cannot simply add it to the shape inherits field. This is because the extended schema might not be present in the API. We will manage this (search the extended schema, add extensions to its inherits
field and compute the minShape) during transformation

Depends on: aml-org/amf-core#474

@nschejtman nschejtman changed the title W 10674627 W 10674627: parse GraphQL type extensions May 26, 2022
antoniogarrote
antoniogarrote previously approved these changes May 26, 2022
Copy link
Contributor

@antoniogarrote antoniogarrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nschejtman nschejtman merged commit 1377e1e into develop May 27, 2022
@nschejtman nschejtman deleted the W-10674627 branch May 27, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants