W-11410812 - Support in draft 2019 as declarations key along with #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pope1838
reviewed
Jul 19, 2022
| val foundDefKeys = definitionsKeys.flatMap(map.key(_)) | ||
| if (foundDefKeys.size > 1) { // If there is more than 1 definition key present in the map | ||
| // TODO add test in the new validation suite | ||
| ctx.eh.warning( |
There was a problem hiding this comment.
If we are going to parse only one key when both are presents, maybe should be a violation instead of a warning?
I think when some information is lost (not parsed) we should throw violations, because some information is not evaluated (and those ignored ast may be invalid at amf)
There was a problem hiding this comment.
We are parsing all the keys (or at least I suppose I do that)
There was a problem hiding this comment.
definitionsKeys.flatMap(defKey => parseDeclarationMap(map, defKey, declarationKeysHolder)).toList
All the declarations in all the keys should be parsing
looseale
force-pushed
the
W-11410812/multi-defs
branch
from
7542adb
to
509ab78
Compare
pope1838
previously approved these changes
Jul 19, 2022
pope1838
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.