Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argument parsing and rendering #1581

Merged
merged 7 commits into from
Sep 7, 2022
Merged

argument parsing and rendering #1581

merged 7 commits into from
Sep 7, 2022

Conversation

nschejtman
Copy link
Contributor

  • Refactor value parsers * Changed root AST node from where parsing starts * Introduced hierarchy * Make 'ValueParser' plugable * Split files
  • W-11691606: Added List & Object value parsers to GraphQL
  • Refactor: parse GraphQL Enum types and Enum values as type Any
  • W-11690316 & W-11691599: GraphQL values rendering * Fix String rendering without quotes * Add add List & Object value rendering
  • W-11691606: Added null value parsers to GraphQL
  • W-11691606: added some tests

@nschejtman nschejtman force-pushed the argument-parsing-and-rendering branch 3 times, most recently from d2329d3 to 2575399 Compare September 6, 2022 20:49
@nschejtman
Adopt changes on new tests:
9baf7d1 
 * Update goldens
 * Momentarily restrict value validation to scalar nodes
@nschejtman nschejtman merged commit 30e13d0 into develop Sep 7, 2022
@nschejtman nschejtman deleted the argument-parsing-and-rendering branch September 7, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hghianni hghianni hghianni approved these changes

@arielmirra arielmirra Awaiting requested review from arielmirra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nschejtman @hghianni