Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W-11350149: adopt VirtualElement changes from core, and some minor refactors #1619

Merged
merged 3 commits into from
Sep 29, 2022
Merged

W-11350149: adopt VirtualElement changes from core, and some minor refactors #1619

merged 3 commits into from
Sep 29, 2022

Conversation

arielmirra
Copy link
Contributor

@arielmirra arielmirra commented Sep 28, 2022 •
edited by tomsfernandez
Loading

  • (refactor): use Eternal trait instead of its mixins
  • (refactor): code cleanup
  • W-11350149: adopt annotation changes from core (VirtualElement is now Eternal)

Related to: aml-org/amf-core#536

@arielmirra arielmirra self-assigned this Sep 28, 2022
@pope1838 pope1838 merged commit 4431d4c into develop Sep 29, 2022
@pope1838 pope1838 deleted the W-11350149 branch September 29, 2022 00:13
@tomsfernandez tomsfernandez mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pope1838 pope1838 pope1838 approved these changes

Assignees

@arielmirra arielmirra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielmirra @pope1838