Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing off by one bug in BAM reader decodeSeqRC #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbyma
Copy link

@sbyma sbyma commented Jun 15, 2017

If decodeSeqRC() receives a read with an odd number of bases, the loop will write into position o_sequence[0] instead of leaving it empty for the final if to fill it in. This commit fixes the bug by adjusting o_sequence_pairs to point one byte beyond the start of o_sequence if the read length is odd numbered.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants