Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research and make a decision on whether body needs width: 100% #3318

Closed
dvoytenko opened this issue May 24, 2016 · 2 comments
Closed

Research and make a decision on whether body needs width: 100% #3318

dvoytenko opened this issue May 24, 2016 · 2 comments
Assignees

Comments

@dvoytenko
Copy link
Contributor

AMP exercises a great control over body element at this time, e.g. by forcing overflow-x: hidden on it and other CSS properties. We may also want to add body {width: 100%}. Some reasons why this may be needed:

  1. The general goal is to ensure that the content properly fist within the visible viewport horizontally. This matters on mobile since we allow horizontal swipe to navigate between documents.
  2. To reconcile differences between different embedding modes, such as iframes vs standalone. E.g. currently on iOS we implicitly have width = 100%.
  3. It might be better due to overflow-x: hidden.

If necessary to experiment with this, this work should proceed via an experiment.

@rudygalfi
Copy link
Contributor

Putting in Backlog for now. @jridgewell, if you plan to work on soon, please change to Current or Next as appropriate. Thanks!

@jridgewell jridgewell modified the milestones: Next, Backlog Jun 22, 2016
@adelinamart
Copy link
Contributor

Hey,

The AMP community has been working nonstop to make AMP better, but somehow we've still managed to grow an enormous backlog of open issues. This has made it difficult for the community to prioritize what we should work on next.

A new process is on the way and to give it a chance for success we will be closing issues that have not been updated in awhile.

If this issue still requires further attention, simply reopen it. Please try to reproduce it with the latest version to ensure it gets proper attention!

We really appreciate the contribution! Thank you for bearing with us as we drag ourselves out of the issue abyss. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants