Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed instructions for adding sqlite dependency in Android #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinogg
Copy link

required to build on the latest version of Android Studio

@sebqq
Copy link

sebqq commented Jan 29, 2019

@martinogg is this related to

\MainApplication.java:XY: error: package org.pgsqlite does not exist import org.pgsqlite.SQLitePluginPackage; 

issue with the newest react-native version 0.58? Because I'm not able to use sqlite-storage with or without your change :/ any advice?

I tried all the three options,, compile, implementation and your change. Only implementation got me through this error but then some other weird errors did show up...

> Android dependency 'com.android.support:support-v4' has different version for the compile (23.0.1) and runtime (26.1.0) classpath. You should manually set the same version via DependencyResolution

@martinogg
Copy link
Author

I tried to re-create the issue you mentioned locally by creating a new empty RN project (0.58.3) then adding in react-native-sqlite-storage using the instructions in the readme.

Don't see the error or warning about com.android.support:support-v4 though I did notice in app/build.gradle is using

implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"

might be something worth checking

@DavidKuennen
Copy link
Contributor

DavidKuennen commented Feb 10, 2019

Also created a new RN Project (0.58.4) and could reproduce the error right away.

@DavidKuennen
Copy link
Contributor

Created a pull request which fixed the issue for me and kinda invalidates this pull request: #324

@andpor
Copy link
Owner

andpor commented Mar 24, 2020

@martinogg @DavidKuennen Is this PR still relevant? Please check and help to resolve the conflict. Please check against latest 5.0.0 release

@andpor
Copy link
Owner

andpor commented Mar 26, 2020

@DavidKuennen David I merged your PR and released it. So I assume this PR can be declined ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants