feat: Show the URL of streaming WASM modules in stack traces

WebAssembly modules compiled through `WebAssembly.compile()` and similar
non-streaming APIs don't have a URL associated to them, because they
have been compiled from a buffer source. In stack traces, V8 will use
a URL such as `wasm://wasm/d1c677ea`, with a hash of the module.

However, wasm modules compiled through streaming APIs, like
`WebAssembly.compileStreaming()`, do have a known URL, which can be
obtained from the `Response` object passed into the streaming APIs. And
as per the developer-facing display conventions in the WebAssembly
Web API spec, this URL should be used in stack traces. This change
implements that.

Closes denoland#12151.

cli/tests/integration/run_tests.rs

@@ -861,6 +861,12 @@ itest!(wasm_unreachable {
  exit_code: 1,
 });
 
+itest!(wasm_url {
+ args: "run --allow-net wasm_url.js",
+ output: "wasm_url.out",
+ exit_code: 1,
+});
+
 itest!(weakref {
  args: "run --quiet --reload weakref.ts",
  output: "weakref.ts.out",

cli/tests/testdata/wasm_unreachable.js

@@ -47,4 +47,6 @@ const binary = Uint8Array.from([
 const module = new WebAssembly.Module(binary);
 const instance = new WebAssembly.Instance(module);
 
+// Compare the stack trace with wasm_url.js, which compiles the WASM module with
+// streaming APIs.
 instance.exports.unreachable();

cli/tests/testdata/wasm_unreachable.out

@@ -1,3 +1,3 @@
 error: Uncaught RuntimeError: unreachable
- at <anonymous> (wasm://wasm/[WILDCARD])
+ at <anonymous> (wasm://wasm/d1c677ea:1:41)
  at [WILDCARD]/wasm_unreachable.js:[WILDCARD]

cli/tests/testdata/wasm_url.js

@@ -0,0 +1,8 @@
+const module = await WebAssembly.compileStreaming(
+ fetch("http://localhost:4545/unreachable.wasm"),
+);
+const instance = new WebAssembly.Instance(module);
+
+// Compare the stack trace with wasm_unreachable.js, which compiles the WASM
+// module with synchronous APIs.
+instance.exports.unreachable();

cli/tests/testdata/wasm_url.out

@@ -0,0 +1,3 @@
+error: Uncaught (in promise) RuntimeError: unreachable
+ at <anonymous> (http://localhost:4545/unreachable.wasm:1:41)
+ at [WILDCARD]/wasm_url.js:[WILDCARD]

core/Cargo.toml

@@ -21,10 +21,10 @@ lazy_static = "1.4.0"
 log = "0.4.14"
 parking_lot = "0.11.1"
 pin-project = "1.0.7"
-rusty_v8 = "0.30.0"
+rusty_v8 = { version = "0.31.0", path = "../../rusty_v8" }
 serde = { version = "1.0.129", features = ["derive"] }
 serde_json = { version = "1.0.66", features = ["preserve_order"] }
-serde_v8 = "0.13.0"
+serde_v8 = { version = "0.14.0", path = "../../serde_v8" }
 url = { version = "2.2.2", features = ["serde"] }
 
 [[example]]

core/lib.deno_core.d.ts

@@ -63,6 +63,8 @@ declare namespace Deno {
  * compiler. Takes the rid and a `Uint8Array`.
  * - `op_wasm_streaming_abort`. Aborts the wasm compilation. Takes the rid
  * and an exception. Invalidates the resource.
+ * - `op_wasm_streaming_set_url`. Sets a source URL for the wasm module.
+ * Takes the rid and a string.
  * - To indicate the end of the resource, use `Deno.core.close()` with the
  * rid.
  */

core/ops_builtin.rs

@@ -26,6 +26,10 @@ pub(crate) fn init_builtins() -> Extension {
  ("op_resources", op_sync(op_resources)),
  ("op_wasm_streaming_feed", op_sync(op_wasm_streaming_feed)),
  ("op_wasm_streaming_abort", op_sync(op_wasm_streaming_abort)),
+ (
+ "op_wasm_streaming_set_url",
+ op_sync(op_wasm_streaming_set_url),
+ ),
  ])
  .build()
 }
@@ -137,3 +141,16 @@ pub fn op_wasm_streaming_abort(
 
  Ok(())
 }
+
+pub fn op_wasm_streaming_set_url(
+ state: &mut OpState,
+ rid: ResourceId,
+ url: String,
+) -> Result<(), AnyError> {
+ let wasm_streaming =
+ state.resource_table.get::<WasmStreamingResource>(rid)?;
+
+ wasm_streaming.0.borrow_mut().set_url(&url);
+
+ Ok(())
+}

ext/fetch/26_fetch.js

@@ -526,6 +526,9 @@
  throw new TypeError(`HTTP status code ${res.status}`);
  }
 
+ // Pass the resolved URL to v8.
+ core.opSync("op_wasm_streaming_set_url", rid, res.url);
+
  // 2.6.
  // Rather than consuming the body as an ArrayBuffer, this passes each
  // chunk to the feed as soon as it's available.