Fix the scroll bar thumb jumping when at the end of the LazyStaggeredList with more than one lane and improve smothness of the scroll #1553
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dList with more than one lane Signed-off-by: Rodrigo Dias Ferreira <[email protected]>
…s on interpolatedIndex
rodrigodiasferreira
changed the title
|
I also transfered the improvement on the smoothness of the scroll from the PR: #1550, into this one, as the generic abstraction was not accepted. |
|
Could you add the result screen video? |
|
Hi @Jaehwa-Noh , sure. Before: After: |
tunjid
reviewed
Aug 12, 2024
...le/samples/apps/nowinandroid/core/designsystem/component/scrollbar/LazyScrollbarUtilities.kt
Outdated
Show resolved
Hide resolved
|
Changes look good to me, I don't work on this project anymore so leaving to the maintainers to approve and merge. |
…nterpolateFirstItemIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
Bug fix: scroll bar thumb jumping when at the end of the LazyStaggeredList with more than one lane, issue described in: #1526.