Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error #151

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Fix build error #151

merged 3 commits into from
Jan 20, 2024

Conversation

chikoski
Copy link
Contributor

@chikoski chikoski commented Jan 18, 2024

This pull request mainly intended to fix the gradle sync failure due to missing androidx-compose-ui-tooling in libs.versions.toml.

In addition to that, the PR includes the following two things:

  • Dependency update
  • Removal of custom clean task from the build.gradle.kts, so that we can run the built-in clean task.
  • A fix of type error in DashBoard.kt

@chikoski chikoski changed the title Fix build error comes from gradle sync failure. Fix build error Jan 18, 2024
@vighnesh153
Copy link
Contributor

FYI: Even this PR was addressing a similar thing: https:/android/tv-samples/pull/145/files

@pankajXdev
Copy link

FYI: Even this PR was addressing a similar thing: https:/android/tv-samples/pull/145/files

It was earlier :/

@JolandaVerhoef
Copy link
Contributor

You're right that it was earlier. However, it did not solve the problem in the correct way, as it didn't add the dependency to the libs.versions.toml file which is the best practice. As this PR includes the right fix and also includes some extra fixes, we'd prefer to directly merge this one.

@chikoski chikoski merged commit 2dfb83c into android:main Jan 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants