Forward default methods

androidx · Sep 16, 2024 · 6e42893 · 6e42893
1 parent 3c6f1f1
commit 6e42893
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 9 deletions.
diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ForwardingRenderer.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ForwardingRenderer.java
@@ -133,6 +133,11 @@ public long getReadingPositionUs() {
  return renderer.getReadingPositionUs();
  }
 
+ @Override
+ public long getDurationToProgressUs(long positionUs, long elapsedRealtimeUs) {
+ return renderer.getDurationToProgressUs(positionUs, elapsedRealtimeUs);
+ }
+
  @Override
  public void setCurrentStreamFinal() {
  renderer.setCurrentStreamFinal();
@@ -153,6 +158,17 @@ public void resetPosition(long positionUs) throws ExoPlaybackException {
  renderer.resetPosition(positionUs);
  }
 
+ @Override
+ public void setPlaybackSpeed(float currentPlaybackSpeed, float targetPlaybackSpeed)
+ throws ExoPlaybackException {
+ renderer.setPlaybackSpeed(currentPlaybackSpeed, targetPlaybackSpeed);
+ }
+
+ @Override
+ public void enableMayRenderStartOfStream() {
+ renderer.enableMayRenderStartOfStream();
+ }
+
  @Override
  public void setTimeline(Timeline timeline) {}
 
@@ -185,4 +201,7 @@ public void disable() {
  public void reset() {
  renderer.reset();
  }
+
+ @Override
+ public void release() {renderer.release();}
 }
diff --git a/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/ForwardingRendererTest.java b/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/ForwardingRendererTest.java
@@ -17,26 +17,26 @@
 
 import static com.google.common.truth.Truth.assertThat;
 
-import androidx.media3.exoplayer.ForwardingRenderer;
-import androidx.media3.exoplayer.Renderer;
 import androidx.media3.test.utils.TestUtil;
+import androidx.test.ext.junit.runners.AndroidJUnit4;
 import java.lang.reflect.Method;
 import java.util.List;
 import org.junit.Test;
+import org.junit.runner.RunWith;
 
+/** Unit tests for {@link ForwardingRenderer}. */
+@RunWith(AndroidJUnit4.class)
 public class ForwardingRendererTest {
  @Test
  public void forwardingRenderer_overridesAllMethods() throws NoSuchMethodException {
  // Check with reflection that ForwardingRenderer overrides all Renderer methods.
  List<Method> methods = TestUtil.getPublicMethods(Renderer.class);
  for (Method method : methods) {
- if (!method.isDefault()) {
- assertThat(
- ForwardingRenderer.class
- .getDeclaredMethod(method.getName(), method.getParameterTypes())
- .getDeclaringClass())
- .isEqualTo(ForwardingRenderer.class);
- }
+ assertThat(
+ ForwardingRenderer.class
+ .getDeclaredMethod(method.getName(), method.getParameterTypes())
+ .getDeclaringClass())
+ .isEqualTo(ForwardingRenderer.class);
  }
  }
 }