Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate text in 1.1.0 release #515

Closed
TacoTheDank opened this issue Jul 12, 2023 · 3 comments
Closed

Duplicate text in 1.1.0 release #515

TacoTheDank opened this issue Jul 12, 2023 · 3 comments

Comments

@TacoTheDank
Copy link

TacoTheDank commented Jul 12, 2023

I didn't know what template to use, so hopefully this is fine.

In https:/androidx/media/releases/tag/1.1.0 and https:/androidx/media/blob/release/RELEASENOTES.md#110-2023-07-05, there is duplicated text under the "Session" section, which needs to be fixed.

The duplicated text in question:

Thank you.

@tonihei
Copy link
Collaborator

tonihei commented Jul 14, 2023

Thanks for reporting, I'll fix this!

@tonihei tonihei self-assigned this Jul 14, 2023
@tonihei tonihei closed this as completed Jul 18, 2023
@TacoTheDank
Copy link
Author

TacoTheDank commented Jul 19, 2023

@tonihei It doesn't seem to have been fixed yet in https:/androidx/media/blob/main/RELEASENOTES.md#110-2023-07-05, unless there's a commit that hasn't been pushed or made public? It's still there in the main development branch?

@tonihei
Copy link
Collaborator

tonihei commented Jul 19, 2023

It has been fixed in https:/androidx/media/releases/tag/1.1.0 and the internal commit to fix the release notes file itself hasn't been uploaded yet. It should appear here the next time someone triggers an upload (about once a week). But note that the fix will be in the "main" branch and only after we've done a 1.1.1 or 1.2.0 release it will also appear to be fixed on the "release" branch.

icbaker pushed a commit that referenced this issue Jul 21, 2023
Issue: #515

#minor-release

PiperOrigin-RevId: 548111465
tianyif pushed a commit that referenced this issue Aug 14, 2023
Issue: #515

#minor-release

PiperOrigin-RevId: 548111465
(cherry picked from commit 42998d6)
@androidx androidx locked and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants