Fix ENCODING_DTS_UHD_P2 bugs. #1294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @cedricxperi, Thank you for creating a pull request to the project. We don't take pull requests into the release branch if you could please fix the PR to be merging into the main branch. Thanks! |
|
@microkatz Hi, Sorry about that. In that case, can I close this pull request and create a new one that merges into the main branch next Monday? Thanks. |
|
@microkatz Closing this pull request and created a new PR that merges to main branch: #1299 Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Direct Passthrough Audio Playback on platforms that supports AudioFormat.ENCODING_DTS_UHD_P2, we need to include C.ENCODING_DTS_UHD_P2 in DefaultAudioSink.getFramesPerEncodedSample() and DefaultAudioTrackBufferSizeProvider.getMaximumEncodedRateBytesPerSecond().