kernel/timeout: Fix off-by-one in absolute timeouts

The computation was using the already-adjusted input value that assumed relative timeouts and not the actual argument the user passed. Absolute timeouts were consistently waking up one tick early. Fixes zephyrproject-rtos#32499 Signed-off-by: Andy Ross <[email protected]>
andyross · Feb 19, 2021 · c4ad8e0 · c4ad8e0
1 parent 71d7f3f
commit c4ad8e0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/kernel/timeout.c b/kernel/timeout.c
@@ -98,7 +98,7 @@ void z_add_timeout(struct _timeout *to, _timeout_func_t fn,
  k_ticks_t ticks = timeout.ticks + 1;
 
  if (IS_ENABLED(CONFIG_TIMEOUT_64BIT) && Z_TICK_ABS(ticks) >= 0) {
- ticks = Z_TICK_ABS(ticks) - (curr_tick + elapsed());
+ ticks = Z_TICK_ABS(timeout.ticks) - (curr_tick + elapsed());
  }
 
  __ASSERT(!sys_dnode_is_linked(&to->node), "");